Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for sub-components (Models.Component.components) #136

Merged
merged 11 commits into from
Jul 29, 2022
Merged

add support for sub-components (Models.Component.components) #136

merged 11 commits into from
Jul 29, 2022

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jul 28, 2022 •
edited

part of #132

added

  • Support for nested/bundled (sub-)components via Models.Component.components was added, including
    serialization/normalization of models and impact on dependency graphs rendering.

implementation

  • data models for Models.Component.components - its another instance of Models.ComponentRepository
    • implement
    • write tests
  • implement normalizer for Models.Component.components
    • JSON
    • XML
    • have tests -- integration tests for all sec versions on normalization and serialization
  • implement dependency tree for Models.Component.components
    • JSON
    • XML
    • have tests -- integration tests for all sec versions on normalization and serialization

@jkowalleck jkowalleck force-pushed the nested-components branch 3 times, most recently from 1149b4a to 3ddcfa7 Compare July 28, 2022 18:09
@jkowalleck
implement component.components in model and basic normalization
e58c297 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
test component.components model
3a02912 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
test component.components normalizer/serializer tests
600a501 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
test component.components normalizer/serializer tests
1ea42a2 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the nested-components branch 4 times, most recently from 5dab837 to a097c38 Compare July 29, 2022 16:08
@jkowalleck
implement dependnecy graph for nested components
96113fa 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
dropped unnessessary object clones when normalizing dependency graph
efb36f8 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
more tests
f949085 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
more verbose change log
e042856 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck marked this pull request as ready for review July 29, 2022 16:48
@jkowalleck jkowalleck requested a review from a team as a code owner July 29, 2022 16:48
@jkowalleck jkowalleck added the enhancement New feature or request label Jul 29, 2022
@jkowalleck
more verbose change log
5356363 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title implement component.components in model and basic normalization add support for Models.Component.components Jul 29, 2022
@jkowalleck jkowalleck changed the title add support for Models.Component.components add support for Models.Component.components[] Jul 29, 2022
@jkowalleck
fix typo
b04a36e 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title add support for Models.Component.components[] add support for sub-components --> Models.Component.components[] Jul 29, 2022
@jkowalleck jkowalleck changed the title add support for sub-components --> Models.Component.components[] add support for sub-components (Models.Component.components[]) Jul 29, 2022
@jkowalleck
hist
fb10eea 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title add support for sub-components (Models.Component.components[]) add support for sub-components (Models.Component.components) Jul 29, 2022
@jkowalleck jkowalleck merged commit 9a12342 into main Jul 29, 2022
@jkowalleck jkowalleck deleted the nested-components branch July 29, 2022 17:31
@jkowalleck jkowalleck mentioned this pull request Jul 29, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jkowalleck