Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageUrlFactory::makeFromComponent() - checksums and download_url #146

Merged
merged 4 commits into from
Aug 1, 2022

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jul 31, 2022

added

  • Factory for PackageURL from Models.Component can handle additional data sources, now.
    • Models.Component.hashes map -> PackageURL.qualifiers.checksum list
    • Models.Component.externalReferences[distribution].url -> PackageURL.qualifiers.download_url
    • Method Factories.PackageUrlFactory.makeFromComponent() got a new optional param sort,
      to indicate whether to go the extra mile and bring hashes and qualifiers in alphabetical order.
      This feature switch is related to reproducible builds.

  • implementation
  • tests

@jkowalleck jkowalleck changed the title PackageUrlFactory::makeFromComponent() checksums and download_url PackageUrlFactory::makeFromComponent() - checksums and download_url Jul 31, 2022
@jkowalleck jkowalleck force-pushed the PackageUrlFactory-more-makeFromComponent branch 2 times, most recently from 9be6e48 to e7a8dbf Compare July 31, 2022 11:11
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the PackageUrlFactory-more-makeFromComponent branch from e7a8dbf to e85e477 Compare July 31, 2022 11:14
@jkowalleck jkowalleck marked this pull request as ready for review July 31, 2022 13:02
@jkowalleck jkowalleck requested a review from a team as a code owner July 31, 2022 13:02
@jkowalleck jkowalleck force-pushed the PackageUrlFactory-more-makeFromComponent branch from 92d6168 to 6a07663 Compare August 1, 2022 06:27
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the PackageUrlFactory-more-makeFromComponent branch from 6a07663 to 39606fe Compare August 1, 2022 06:34
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck merged commit e05f837 into main Aug 1, 2022
@jkowalleck jkowalleck deleted the PackageUrlFactory-more-makeFromComponent branch August 1, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant