fix: digest library as JavaScript module build by TypeScript #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage summary from CodacyMerging #596 (219c887) into
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
jkowalleck
force-pushed
the
fix-TSesm-digest
branch
2 times, most recently
from
bd7e385
to
61ba718
Compare
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
force-pushed
the
fix-TSesm-digest
branch
from
61ba718
to
10039ca
Compare
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
force-pushed
the
fix-TSesm-digest
branch
from
53908fc
to
0caf55b
Compare
jkowalleck
commented
Mar 28, 2023
| }, | ||
| "browser": "./dist.web/lib.js", | ||
| "types": "./dist.d/index.node.d.ts", | ||
| "main": "./dist.node/index.node.js", | ||
| "exports": "./dist.node/index.node.js", | ||
| "exports": { |
There was a problem hiding this comment.
ℹ️ this is the actual fix
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it appeared like there was an issue when digesting this very library in another (downstream) TypeScript project that was intended to compile to native ECMA script modules.
to check, integration tests were added,
and a fix/solution was implemented -- fix the
package.json'sexportssetting.