CDX document validation #652

jkowalleck · 2023-04-14T14:33:17Z

fixes #620

JSON validator - Json validator runtime #645
XML validator - Validation libxml2 #668
docs, history, readme
have a release candidate integrated in other tools to test compat
implement successfullt in other tools

out of scope: enhance normalizers

json.isIriReference
json.isIdnEmail
xml.isAnyURI

blocked by:

iri-reference generated by CycloneDX invalid? luzlab/ajv-formats-draft2019#22
- desired workaround: JSON runtime-validate against this format where needed, and omit strings that appear invalid.
- similar can be done to XML
- -> validation of format iri-reference was just skipped for now

codacy-production · 2023-04-14T14:37:12Z

Coverage summary from Codacy

Merging #652 (401a22a) into main (c7d9a87) - See PR on Codacy

Coverage variation	Diff coverage
✅ +0.09% (target: -1.00%)	✅ 99.51% (target: 90.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`c7d9a87`)	5500	5403	98.24%
Head commit (`401a22a`)	5902 (+402)	5803 (+400)	98.32% (+0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#652)	407	405	99.51%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

tests/integration/Serialize.JsonNormalize.test.js

tools/schema-downloader/download.js

package.json

* docs Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * deps Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * prep structures Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * impl Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * impl Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * impl Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * impl Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * impl Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * impl Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * impl Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * docs Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * opt dep tests Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * tests Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * inm test Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * inm test Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * error classes Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * validate in serialization tests Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> * tests Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> --------- Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

jkowalleck added the enhancement New feature or request label Apr 14, 2023

jkowalleck commented Apr 14, 2023

View reviewed changes

tests/integration/Serialize.JsonNormalize.test.js Outdated Show resolved Hide resolved

sonatype-lift bot reviewed Apr 17, 2023

View reviewed changes

tools/schema-downloader/download.js Show resolved Hide resolved

jkowalleck force-pushed the validation-dev branch from da38a87 to d89629a Compare April 17, 2023 12:29

jkowalleck changed the title ~~[WIP] validators~~ [WIP] CDX BOM validation Apr 17, 2023

jkowalleck force-pushed the validation-dev branch 2 times, most recently from 48c6e3c to 1142929 Compare April 19, 2023 16:34

sonatype-lift bot reviewed Apr 19, 2023

View reviewed changes

package.json Show resolved Hide resolved

jkowalleck marked this pull request as ready for review April 20, 2023 07:23

jkowalleck requested a review from a team as a code owner April 20, 2023 07:23

jkowalleck changed the title ~~[WIP] CDX BOM validation~~ CDX BOM validation Apr 21, 2023

jkowalleck changed the title ~~CDX BOM validation~~ CDX document validation Apr 21, 2023

jkowalleck added the QA label Apr 21, 2023

jkowalleck mentioned this pull request Apr 21, 2023

feat: validate results CycloneDX/cyclonedx-node-npm#660

Merged

5 tasks

jkowalleck marked this pull request as draft April 22, 2023 10:05

jkowalleck added 14 commits April 23, 2023 12:56

downlaoder fixer

314e4ef

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

downlaoder adjust

dda2492

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

add opt deps to lock

d454e0b

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

test clean

a298268

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

imprv paralelism in JSON validators (#664)

a7b3201

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

Validation libxml2 (#668)

45fb2c9

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

streamline

238195b

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

test tidy

acde4d7

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

example package names

e87d83c

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

ci: workflow correction for examples

c9d752b

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

namespace adjusts for validation

c3c1e6c

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

example adjusts

abe17c7

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

docs

c37d43e

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

jkowalleck and others added 14 commits April 23, 2023 12:56

docs

f9b446c

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

fix throw message

05d9c1a

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

fix examples

870d334

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

HISTORY

ab111ed

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

improved debuggability

a47e087

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

prerelease 1.14.0-rc.0

710ec84

decision paters

0187f42

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

readability

7836df1

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

test: examples for iri-reference

c3eb1e7

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

skip iri validations

0f09c2b

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

docs

4ee3b09

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

docs

01604a5

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

recreate composer lock after rebase

1a82744

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

cs-fix

401a22a

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

jkowalleck force-pushed the validation-dev branch from dc8599b to 401a22a Compare April 23, 2023 11:09

jkowalleck marked this pull request as ready for review April 23, 2023 11:10

jkowalleck added 3 commits April 23, 2023 13:18

docs

105d3e6

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

package

0ea66d8

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

tests streamlined

0560fb9

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

jkowalleck merged commit 5e15536 into main Apr 23, 2023
31 of 32 checks passed

jkowalleck deleted the validation-dev branch April 23, 2023 11:37

This was referenced Apr 23, 2023

add {JSON,XML} schema validators #620

Closed

feat: bom.vulnerabilities JSON normalization #548

Merged

jkowalleck mentioned this pull request May 17, 2023

feat: Deserializer/Denormalizer #86

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CDX document validation #652

CDX document validation #652

jkowalleck commented Apr 14, 2023 •

edited

codacy-production bot commented Apr 14, 2023 •

edited

CDX document validation #652

CDX document validation #652

Conversation

jkowalleck commented Apr 14, 2023 • edited

codacy-production bot commented Apr 14, 2023 • edited

Coverage summary from Codacy

See your quality gate settings Change summary preferences

jkowalleck commented Apr 14, 2023 •

edited

codacy-production bot commented Apr 14, 2023 •

edited