Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metadata.lifecycles #946

Merged
merged 6 commits into from
Aug 16, 2023
Merged

feat: add metadata.lifecycles #946

merged 6 commits into from
Aug 16, 2023

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Aug 13, 2023

  • BREAKING
    • Interface Spec.Protocol now defines new mandatory methods
      This is only a breaking change if you custom-implemented this interface downstream; internal usage is non-breaking.
  • Added
    • New enum Enums.Lifecycle with corresponding values from CycloneDX Specification-1.5
    • New class Models.NamedLifecycle
    • New class Models.LifecycleRepository
    • Class Models.Metadata got a new property lifecycles
    • Serializers and Metadata-Normalizers will take Models.Metadata.lifecycles into account

fixes #937


  • add enum for LifecyclePhase
  • add data models
  • add JSON normalizer
  • add XML normalizer
  • add tests
  • write history -- make BC known

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added enhancement New feature or request schema 1.5 related to CycloneDX spec v1.5 labels Aug 13, 2023
@jkowalleck jkowalleck requested a review from a team as a code owner August 13, 2023 15:59
@jkowalleck jkowalleck marked this pull request as draft August 13, 2023 15:59
@jkowalleck jkowalleck changed the title feat: add Enums.LifecyclePhase [WIP] feat: add Enums.LifecyclePhase Aug 13, 2023
@jkowalleck jkowalleck changed the title [WIP] feat: add Enums.LifecyclePhase [WIP] feat: add metadata.lifecycles Aug 13, 2023
@codacy-production
Copy link

codacy-production bot commented Aug 13, 2023

Coverage summary from Codacy

Merging #946 (b49d737) into main (156bdfa) - See PR on Codacy

Coverage variation Diff coverage
-0.04% (target: -1.00%) 96.69% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (156bdfa) 6993 6872 98.27%
Head commit (b49d737) 7171 (+178) 7044 (+172) 98.23% (-0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#946) 181 175 96.69%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck self-assigned this Aug 16, 2023
src/spec.ts Show resolved Hide resolved
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck marked this pull request as ready for review August 16, 2023 11:00
@jkowalleck jkowalleck changed the title [WIP] feat: add metadata.lifecycles feat: add metadata.lifecycles Aug 16, 2023
@jkowalleck jkowalleck merged commit 1f98271 into main Aug 16, 2023
34 checks passed
@jkowalleck jkowalleck deleted the metadata-evidence branch August 16, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request schema 1.5 related to CycloneDX spec v1.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support metadata.lifecycles
1 participant