Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC: make Spec.Protocol internal #958

Merged
merged 6 commits into from
Aug 27, 2023
Merged

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Aug 26, 2023

fixes #957


  • implement
  • write docs and history

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@codacy-production
Copy link

codacy-production bot commented Aug 26, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 0ebfd141 100.00% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0ebfd14) Report Missing Report Missing Report Missing
Head commit (4547e8f) 7244 7117 98.25%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#958) 227 227 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jkowalleck jkowalleck changed the title BC: make Spec.Protocol private BC: make Spec.Protocol internal Aug 26, 2023
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck marked this pull request as ready for review August 27, 2023 08:26
@jkowalleck jkowalleck requested a review from a team as a code owner August 27, 2023 08:26
@jkowalleck jkowalleck merged commit cdf642c into main Aug 27, 2023
36 checks passed
@jkowalleck jkowalleck deleted the bc_spec_interface_internal branch August 27, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BC: make Spec.Protocol internal
1 participant