Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow testing with maven-it-extension and JUnit 5 #227

Closed
robertk3s opened this issue Dec 7, 2022 · 0 comments · Fixed by #228
Closed

Allow testing with maven-it-extension and JUnit 5 #227

robertk3s opened this issue Dec 7, 2022 · 0 comments · Fixed by #228

Comments

@robertk3s
Copy link
Contributor

Hi,

I would like try to reproduce #111 with a test but had some troubles getting it done with takari. I would like to use a different approach using:
https://dzone.com/articles/maven-plugin-testing-in-a-modern-way-part-i
https://github.com/khmarbaise/maven-it-extension

And that would might be helpful for future tests as well. However this is a JUnit 5 extension, so the project would need to support JUnit5.
So if possible, I would like to add JUnit 5 with the vintage engine to support both testing approaches.
(see https://junit.org/junit5/docs/current/user-guide/#migrating-from-junit4-running)
I would do this change in a PR.

robertk3s added a commit to robertk3s/cyclonedx-maven-plugin that referenced this issue Dec 7, 2022
robertk3s added a commit to robertk3s/cyclonedx-maven-plugin that referenced this issue Dec 7, 2022
Signed-off-by: Robert Klaus <robert.klaus@posteo.net>
stevespringett added a commit that referenced this issue Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant