Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add smoke tests for makeBom and makeAggregateBom #234

Merged
merged 1 commit into from
Dec 22, 2022
Merged

add smoke tests for makeBom and makeAggregateBom #234

merged 1 commit into from
Dec 22, 2022

Conversation

hboutemy
Copy link
Contributor

useful to basically show normal usage and see output

@hboutemy
Copy link
Contributor Author

hboutemy commented Dec 22, 2022 •
edited
Loading

notice that makeAggregateBom cause [WARNING] artifact org.cyclonedx.its:util:json:cyclonedx:1.0-SNAPSHOT already attached, replace previous instance
aggregate run creates + attaches BOM for every module, then every modules re-create and re-attach everything for each module
I'll work on a fix...

@hboutemy
add smoke tests for makeBom and makeAggregateBom
f576a4c 
Signed-off-by: Hervé Boutemy <hboutemy@apache.org>
@stevespringett
Copy link
Member

Thanks for the PR. Much appreciated.

I'll work on a fix...

Fantastic. I've noticed that as well.

@stevespringett stevespringett merged commit c3f4bc1 into CycloneDX:master Dec 22, 2022
@hboutemy hboutemy deleted the its branch December 23, 2022 11:38
hboutemy added a commit to hboutemy/cyclonedx-maven-plugin that referenced this pull request Dec 23, 2022
@hboutemy
fix multiple times BOM generation on multi-module makeAggregateBom
ad434c4 
fixes bug introduced in CycloneDX#181, reported in CycloneDX#234

Signed-off-by: Hervé Boutemy <hboutemy@apache.org>
@hboutemy hboutemy mentioned this pull request Dec 23, 2022
Merged
hboutemy added a commit to hboutemy/cyclonedx-maven-plugin that referenced this pull request Dec 23, 2022
@hboutemy
fix multiple times BOM generation on multi-module makeAggregateBom
79ec5c8 
fixes bug introduced in CycloneDX#181, reported in CycloneDX#234

Signed-off-by: Hervé Boutemy <hboutemy@apache.org>
hboutemy added a commit to hboutemy/cyclonedx-maven-plugin that referenced this pull request Dec 27, 2022
@hboutemy
fix multiple times BOM generation on multi-module makeAggregateBom
de1acbc 
fixes bug introduced in CycloneDX#181, reported in CycloneDX#234

Signed-off-by: Hervé Boutemy <hboutemy@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hboutemy @stevespringett