mark makeBom and makeAggregatedBom threadsafe as makePackageBom #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no issue in code like static fields fixes CycloneDX#77 Signed-off-by: Hervé Boutemy <hboutemy@apache.org>
|
Thanks for verifying the code @hboutemy. Much appreciated. |
|
Well this is interesting... The PR has been merged. It can be verified in the git history. https://github.com/CycloneDX/cyclonedx-maven-plugin/commits/master and yet the PR itself was not closed. Looks like a bug in GitHub itself. |
|
Verified that updating the project locally contains the contents of this PR. Manually closing. |
hboutemy
pushed a commit
to hboutemy/cyclonedx-maven-plugin
that referenced
this pull request
Jan 25, 2023
mark makeBom and makeAggregatedBom threadsafe as makePackageBom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue in code like static fields
fixes #77