move code out of base when possible #268
Conversation
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/CycloneDX/cyclonedx-maven-plugin/268.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/CycloneDX/cyclonedx-maven-plugin/268.diff | git applyOnce you're satisfied commit and push your changes in your project. Footnotes |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -331,7 +304,7 @@ protected boolean shouldInclude(Artifact artifact) { | |||
| * @param project the MavenProject to convert | |||
| * @return a CycloneDX Metadata object | |||
| */ | |||
| protected Metadata convert(final MavenProject project) { | |||
| private Metadata convert(final MavenProject project) { | |||
There was a problem hiding this comment.
Var: Unnecessary 'final' modifier.
| private Metadata convert(final MavenProject project) { | |
| private Metadata convert(MavenProject project) { |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -415,7 +388,7 @@ protected Component convert(Artifact artifact) { | |||
| return component; | |||
| } | |||
|
|
|||
| private String generatePackageUrl(final Artifact artifact) { | |||
| protected String generatePackageUrl(final Artifact artifact) { | |||
There was a problem hiding this comment.
Var: Unnecessary 'final' modifier.
| protected String generatePackageUrl(final Artifact artifact) { | |
| protected String generatePackageUrl(Artifact artifact) { |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -415,7 +388,7 @@ protected Component convert(Artifact artifact) { | |||
| return component; | |||
| } | |||
|
|
|||
| private String generatePackageUrl(final Artifact artifact) { | |||
| protected String generatePackageUrl(final Artifact artifact) { | |||
There was a problem hiding this comment.
UnnecessaryFinal: Since Java 8, it's been unnecessary to make local variables and parameters final for use in lambdas or anonymous classes. Marking them as final is weakly discouraged, as it adds a fair amount of noise for minimal benefit.
| protected String generatePackageUrl(final Artifact artifact) { | |
| protected String generatePackageUrl( Artifact artifact) { |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -331,7 +304,7 @@ protected boolean shouldInclude(Artifact artifact) { | |||
| * @param project the MavenProject to convert | |||
| * @return a CycloneDX Metadata object | |||
| */ | |||
| protected Metadata convert(final MavenProject project) { | |||
| private Metadata convert(final MavenProject project) { | |||
There was a problem hiding this comment.
UnnecessaryFinal: Since Java 8, it's been unnecessary to make local variables and parameters final for use in lambdas or anonymous classes. Marking them as final is weakly discouraged, as it adds a fair amount of noise for minimal benefit.
| private Metadata convert(final MavenProject project) { | |
| private Metadata convert( MavenProject project) { |
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| private static final String MESSAGE_CREATING_BOM = "CycloneDX: Creating BOM"; | ||
| private static final String MESSAGE_CALCULATING_HASHES = "CycloneDX: Calculating Hashes"; | ||
| private static final String MESSAGE_WRITING_BOM = "CycloneDX: Writing BOM (%s): %s"; | ||
| private static final String MESSAGE_VALIDATING_BOM = "CycloneDX: Validating BOM (%s): %s"; |
There was a problem hiding this comment.
InlineFormatString: Prefer to create format strings inline, instead of extracting them to a single-use constant
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| protected ProjectDependencyAnalyzer dependencyAnalyzer; | ||
| private static final String MESSAGE_CREATING_BOM = "CycloneDX: Creating BOM"; | ||
| private static final String MESSAGE_CALCULATING_HASHES = "CycloneDX: Calculating Hashes"; | ||
| private static final String MESSAGE_WRITING_BOM = "CycloneDX: Writing BOM (%s): %s"; |
There was a problem hiding this comment.
InlineFormatString: Prefer to create format strings inline, instead of extracting them to a single-use constant
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Signed-off-by: Hervé Boutemy <hboutemy@apache.org>
| } | ||
|
|
||
| /** | ||
| * @return {@link ProjectDependencyAnalyzer} |
There was a problem hiding this comment.
MissingSummary: A summary line is required on public/protected Javadocs.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
this will ease base class maintenance