New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #284, Switch to aether and filter artifacts based on individual… #302

Merged

hboutemy merged 1 commit into CycloneDX:master from knrc:issue-284

Mar 3, 2023

Contributor

knrc commented Mar 1, 2023

… scopes

sonatype-lift bot reviewed

View reviewed changes

src/main/java/org/cyclonedx/maven/BaseCycloneDxMojo.java Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

src/main/java/org/cyclonedx/maven/CycloneDxRepositorySystem.java Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

src/main/java/org/cyclonedx/maven/BaseCycloneDxMojo.java Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

src/main/java/org/cyclonedx/maven/BaseCycloneDxMojo.java Outdated Show resolved Hide resolved

sonatype-lift bot commented Mar 1, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.¹

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/CycloneDX/cyclonedx-maven-plugin/302.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/CycloneDX/cyclonedx-maven-plugin/302.diff | git apply

Once you're satisfied, commit and push your changes in your project.

You can preview the patch by opening the patch URL in the browser. ↩

knrc force-pushed the issue-284 branch 2 times, most recently from be0d05f to 2bddc70 Compare

March 1, 2023 20:56

sonatype-lift bot reviewed

View reviewed changes

src/main/java/org/cyclonedx/maven/BaseCycloneDxMojo.java Show resolved Hide resolved


          Fixes CycloneDX#284, Switch to aether and filter artifacts based on i…

8f4821b

…ndividual scopes

Signed-off-by: Kevin Conner <kev.conner@gmail.com>

knrc force-pushed the issue-284 branch from 2bddc70 to 8f4821b Compare

March 1, 2023 21:06

hboutemy added the bug label

hboutemy merged commit feca68c into CycloneDX:master

hboutemy linked an issue

that may be closed by this pull request

2.7.5 release does not obey includeProvidedScope option #284

Closed

Contributor

hboutemy commented Mar 3, 2023

thank you @knrc , even if I'll need to rework my #301 :)

Contributor Author

knrc commented Mar 3, 2023

@hboutemy Sorry about that, I hope it's not too painful

Contributor

hboutemy commented Mar 4, 2023

no worries, it's done: I prefer having you working in parallel than being alone :)

hboutemy mentioned this pull request

makeAggregateBom includes provided and system scope dependencies when they are excluded #328

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment