Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Reproducible SBOM: drop UUID and timestamp when RB mode enabled #353

Merged
merged 2 commits into from
May 6, 2023

Conversation

hboutemy
Copy link
Contributor

@hboutemy hboutemy commented May 3, 2023

fixes #226

when Maven Reproducible Builds mode is detected (with project.build.outputTimestamp), non-reproducible UUID and timestamp are just removed from SBOM

fixes #226

Signed-off-by: Hervé Boutemy <hboutemy@apache.org>
Signed-off-by: Hervé Boutemy <hboutemy@apache.org>
@hboutemy hboutemy merged commit 44048e9 into master May 6, 2023
5 checks passed
@hboutemy hboutemy deleted the reproducible-sbom branch May 6, 2023 14:37
@aalmiray
Copy link

aalmiray commented May 6, 2023

Why is the timestamp removed when a reproducible build is requested? Wouldn‘t it make sense to use the supplied timestamp?

@hboutemy
Copy link
Contributor Author

hboutemy commented May 8, 2023

because SBOM defines the semantics of timestamp as the time of the build
instead of starting to discuss what is the semantics of project.build.outputTimestamp (which by experience can get very long and non-productive, just for timestamp in jar that nobody cared until now), just not putting a timestamp will be clearer to show that "something is happening" (and this PR added a property to show that the something is Reproducible Builds mode)

@aalmiray
Copy link

aalmiray commented May 8, 2023

Understood. Will propose the same changes to the Gradle plugin.

@hboutemy
Copy link
Contributor Author

notice that reproducible UUIDs have been implemented in #425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude or set metadata/timestamp for Reproducible Builds
2 participants