-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document SBOM external references #459
Conversation
aae4a13
to
e0e7a0f
Compare
Signed-off-by: Hervé Boutemy <hboutemy@apache.org>
e0e7a0f
to
df83d58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@@ -215,7 +215,7 @@ private void checkTopLevelTestComponentsAsCompile(final File projDir) throws Exc | |||
|
|||
/** | |||
* This test ensures that any <i>compile</i> dependencies hidden by excluded types are included in the BOM if they are visible dependencies | |||
* @throws Exception | |||
* @throws Exception if something unexpected happens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: we really need to document tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or there is a warning at build time: just added minimum text to avoid warning
Signed-off-by: Volkan Yazıcı <volkan@yazi.ci>
Signed-off-by: Volkan Yazıcı <volkan@yazi.ci>
default external references filled from POM + additional ones configured in plugin
while at it, also documented other fields converted from POM