Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more logs & configurable log level #1131

Merged
merged 10 commits into from
Dec 8, 2023
Merged

feat: more logs & configurable log level #1131

merged 10 commits into from
Dec 8, 2023

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Dec 7, 2023

Changed

  • Log output is less verbose, can be re-enabled via CLI switch --verbose
    Warnings and errors are still displayed as before.
    This is considered a non-breaking change, since only informational logs and debug information is affected.

Added

  • CLI switch -v, --verbose to increase output verbosity
    May be used multiple times, like -vvv.
  • More logs on info-level
  • More logs on debug-level

fixes #158

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck requested a review from a team as a code owner December 7, 2023 12:40
@jkowalleck jkowalleck added the enhancement New feature or request label Dec 7, 2023
@jkowalleck
Copy link
Member Author

debatable, whether this is a breaking change or not.
i'd argue that it is not, since the console log output was never API-like, and was intended for humans.

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Copy link

codacy-production bot commented Dec 7, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.15% 91.30% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0d684b9) 1092 936 85.71%
Head commit (a918ec2) 1146 (+54) 984 (+48) 85.86% (+0.15%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1131) 23 21 91.30%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title feat: very simple output logger feat: more logs & configurable log level Dec 7, 2023
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck merged commit 436c85d into main Dec 8, 2023
33 checks passed
@jkowalleck jkowalleck deleted the my-simple-logger branch December 8, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rework logging/output
1 participant