Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document how to change npm executable #647

Merged
merged 5 commits into from
Apr 16, 2023
Merged

docs: document how to change npm executable #647

merged 5 commits into from
Apr 16, 2023

Conversation

igord
Copy link
Contributor

@igord igord commented Apr 14, 2023 •
edited by jkowalleck
Loading

  • Docs
    • Describe internal npm executable detection in README

docs: document how to change npm executable
672b7b5 
Signed-off-by: Igor Dimitrijevic <grmail@gmail.com>
@igord igord requested a review from a team as a code owner April 14, 2023 15:34
jkowalleck
jkowalleck reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@jkowalleck jkowalleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the enhancement. could you incorporate some changes?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jkowalleck jkowalleck added the documentation Improvements or additions to documentation label Apr 14, 2023
@jkowalleck
Copy link
Member

jkowalleck commented Apr 14, 2023 •
edited
Loading

Thanks for the documentation, @igord .

Could you sign-off your commits, to show that you agree publising your contribution under the current license of this project?
see https://github.com/CycloneDX/cyclonedx-node-npm/blob/main/CONTRIBUTING.md#sign-off-your-commits

ℹ️ how to :
see https://github.com/CycloneDX/cyclonedx-node-npm/pull/647/checks?check_run_id=12756708646

Igor Dimitrijevic added 2 commits April 14, 2023 19:06
docs: improve npm executable description
85e0b91 
Signed-off-by: Igor Dimitrijevic <grmail@gmail.com>
docs: npm executable update history file
4df40ce 
Signed-off-by: Igor Dimitrijevic <grmail@gmail.com>
@jkowalleck
docs: reword & move npm exec desc
79f00b7 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
docs: link in history
1e97ed9 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck merged commit ee49351 into CycloneDX:main Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowalleck jkowalleck jkowalleck left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@igord @jkowalleck