Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ease tree shaking #93

Merged
merged 2 commits into from
May 15, 2024
Merged

refactor: ease tree shaking #93

merged 2 commits into from
May 15, 2024

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented May 14, 2024

the previous code was not easy to tree-shake.
this caused a much too large build result, which included unused chunks...

lets ease the tree shaking


old:

➤ YN0000: ? Bundle size: 778.13 KiB

new:

➤ YN0000: ? Bundle size: 574.05 KiB

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck requested a review from a team as a code owner May 14, 2024 17:35
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.69% 77.27% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f45b872) 1968 1254 63.72%
Head commit (521ad68) 2082 (+114) 1341 (+87) 64.41% (+0.69%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#93) 66 51 77.27%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@jkowalleck jkowalleck merged commit 128de7e into 1.0-dev May 15, 2024
22 of 24 checks passed
@jkowalleck jkowalleck deleted the refactor/import-subpaths branch May 15, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant