Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementation of xsd:anyURI is invalid #18

Closed
jkowalleck opened this issue Nov 14, 2021 · 0 comments · Fixed by #19
Closed

implementation of xsd:anyURI is invalid #18

jkowalleck opened this issue Nov 14, 2021 · 0 comments · Fixed by #19
Assignees
@jkowalleck
Labels
bug Something isn't working

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Nov 14, 2021 •
edited

ISSUE: current implementation treats xsd:anyURI as an URL.

xsd:anyURI is more than a URL
documentation: http://www.w3.org/TR/xmlschema-2/#anyURI
see also http://books.xmlschemata.org/relaxng/ch19-77009.html
see also http://www.datypic.com/sc/xsd/t-xsd_anyURI.html

current implementation is done wrong - as followed:

filter_var($url, \FILTER_VALIDATE_URL)
@jkowalleck jkowalleck added the bug Something isn't working label Nov 14, 2021
@jkowalleck jkowalleck self-assigned this Nov 14, 2021
jkowalleck added a commit that referenced this issue Nov 14, 2021
@jkowalleck
needs a fix #18
f2a89da
jkowalleck added a commit that referenced this issue Nov 14, 2021
@jkowalleck
remove url validation of `CycloneDX\Core\Models\License\AbstractDisju…
9ed937e 
…nctiveLicense::setUrl()`

fixes #18
@jkowalleck jkowalleck mentioned this issue Nov 14, 2021
Merged
jkowalleck added a commit that referenced this issue Nov 14, 2021
@jkowalleck
remove url validation of `CycloneDX\Core\Models\License\AbstractDisju…
80640b3 
…nctiveLicense::setUrl()`

fixes #18

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Nov 15, 2021
@jkowalleck
1.0.3
49d73ec 
* Fixed
  * `CycloneDX\Core\Models\License\AbstractDisjunctiveLicense::setUrl()`
    no longer restricts the argument to be a valid URL.
    Per schema definition `licenseType.url` should be a URI, not a URL.
    See [#18](#18)
* Changed
  * `CycloneDX\Core\Models\License\AbstractDisjunctiveLicense::setUrl()`
     no longer throws `InvalidArgumentException`
     if the argument is not a URL (via [#19])

[#19]: #19
jkowalleck added a commit that referenced this issue Nov 20, 2021
@jkowalleck
remove url validation of `CycloneDX\Core\Models\License\AbstractDisju…
9481e41 
…nctiveLicense::setUrl()`

fixes #18

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Nov 20, 2021
@jkowalleck
1.0.3
3157006 
* Fixed
  * `CycloneDX\Core\Models\License\AbstractDisjunctiveLicense::setUrl()`
    no longer restricts the argument to be a valid URL.
    Per schema definition `licenseType.url` should be a URI, not a URL.
    See [#18](#18)
* Changed
  * `CycloneDX\Core\Models\License\AbstractDisjunctiveLicense::setUrl()`
     no longer throws `InvalidArgumentException`
     if the argument is not a URL (via [#19])

[#19]: #19

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck mentioned this issue Dec 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkowalleck jkowalleck

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@jkowalleck