Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC: UpperCamelCase enum names #256

Closed
jkowalleck opened this issue Mar 10, 2023 · 0 comments · Fixed by #257
Closed

BC: UpperCamelCase enum names #256

jkowalleck opened this issue Mar 10, 2023 · 0 comments · Fixed by #257
Assignees
Milestone

Comments

@jkowalleck
Copy link
Member

the enum classes became native enums via #140

This means we dont have consts, but cases.
Constants were written in uppercase in the past, which originates to times when here when no IDEs, so people would easily know these were constants not properties ....

this is outdated foo.

Let's rename the cases and user UpperCamelCase for naming conventions.
And while on it, sort them alphabetically.

@jkowalleck jkowalleck added this to the v2 milestone Mar 10, 2023
@jkowalleck jkowalleck self-assigned this Mar 10, 2023
@jkowalleck jkowalleck changed the title BC: lowercase enum names BC: UpperCamelCase enum names Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant