Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP8.1] use native enums #140

Closed
jkowalleck opened this issue Sep 25, 2022 · 0 comments · Fixed by #204
Closed

[PHP8.1] use native enums #140

jkowalleck opened this issue Sep 25, 2022 · 0 comments · Fixed by #204
Assignees
@jkowalleck
Labels
breaking change
Milestone
v2

Comments

@jkowalleck
Copy link
Member

current implementation uses abstract classes for enums.

since version 8.1 PHP finally has native enum support. see https://www.php.net/manual/en/language.types.enumerations.php

proposal: change all enum-likes to actual enums
@jkowalleck jkowalleck changed the title PHP8.1 use enums [PHP8.1] use enums Sep 25, 2022
@jkowalleck jkowalleck changed the title [PHP8.1] use enums [PHP8.1] use native enums Sep 27, 2022
@jkowalleck jkowalleck added this to the v2 milestone Feb 4, 2023
@jkowalleck jkowalleck self-assigned this Feb 4, 2023
@jkowalleck jkowalleck mentioned this issue Feb 4, 2023
Merged
jkowalleck added a commit that referenced this issue Feb 4, 2023
@jkowalleck
native php eunis (#204)
9a83010 
fixes #140

* raise php requirement from `8.0` to `8.1`
* convert all enum classes to be native PHP enums


Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck mentioned this issue Mar 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkowalleck jkowalleck

Labels
breaking change
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

native php enum CycloneDX/cyclonedx-php-library
1 participant
@jkowalleck