Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make XmlSerializer's properties accessable #305

Closed
jkowalleck opened this issue Jun 1, 2023 · 2 comments · Fixed by #306
Closed

make XmlSerializer's properties accessable #305

jkowalleck opened this issue Jun 1, 2023 · 2 comments · Fixed by #306
Labels
enhancement New feature or request

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Jun 1, 2023

XmlSerializer's properties xmlVersion and xmlEncoding are currently private.
goal: make them visible/accessible for inheriting structures.
caused by #304 (reply in thread)


options for a solution:

  • a) add protected getters
  • b) make properties protected readonly -- since this lib requires php:^8.1

preferred solution: b)


this is considered a non-breaking change, as an access is widened.

@jkowalleck jkowalleck added the enhancement New feature or request label Jun 1, 2023
@jkowalleck
Copy link
Member Author

@llaville FYI

@llaville
Copy link

llaville commented Jun 1, 2023

preferred solution b) too !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants