Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch JSON schema validator to 'opis/json-schema' #80

Closed
2 of 4 tasks
jkowalleck opened this issue Mar 8, 2022 · 0 comments · Fixed by #151
Closed
2 of 4 tasks

switch JSON schema validator to 'opis/json-schema' #80

jkowalleck opened this issue Mar 8, 2022 · 0 comments · Fixed by #151
Milestone
v2

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Mar 8, 2022 •
edited

the decision paper has a section about switching to a better json schema validator, when possible.

this time has come: the schema files were fixed, php7.3 is no longer supported.
let's switched to opis/json-schema for JSON validation

acc / crit:

  • opis/json-schema is used for JSON validation in productive code
  • opis/json-schema is used for JSON validation in tests
  • other json schema validator dependencies were removed
  • updated decision paper describing the terms of the current schema validator, and hint to older version of the document.

❗ currently blocked by CycloneDX/specification#138
@jkowalleck jkowalleck added this to the v2 milestone Mar 8, 2022
@jkowalleck jkowalleck changed the title switch it 'opis/json-schema' switch JSON schema validator to 'opis/json-schema' Mar 8, 2022
@jkowalleck jkowalleck mentioned this issue Sep 29, 2022
Merged
jkowalleck added a commit that referenced this issue Sep 30, 2022
@jkowalleck
Switch json validator to opis/json-schema (#151)
b5f47ac 
* depend on `opis/json-schema` (see #80)
* implement according to new validator
* remove some helpers that are not needed anymore
* made JSON url normalization more constistent

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

Switch json validator to opis/json-schema CycloneDX/cyclonedx-php-library
1 participant
@jkowalleck