Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add spec factory #142

Merged
merged 1 commit into from Sep 25, 2022
Merged

add spec factory #142

merged 1 commit into from Sep 25, 2022

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Sep 25, 2022 •
edited

fixes #139

  • implement
  • write tests
  • write history

@jkowalleck jkowalleck added this to the v2 milestone Sep 25, 2022
@jkowalleck jkowalleck force-pushed the specs-to-factory branch 2 times, most recently from 2c31dba to bac2eea Compare September 25, 2022 13:03
@jkowalleck
add spec factory
546a2be 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck marked this pull request as ready for review September 25, 2022 13:11
@jkowalleck jkowalleck requested a review from a team as a code owner September 25, 2022 13:11
@jkowalleck jkowalleck merged commit 1d2961f into master Sep 25, 2022
@jkowalleck jkowalleck deleted the specs-to-factory branch September 25, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.

Spec: instances instead of classes for spec versions
1 participant
@jkowalleck