Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework serializers #155

Merged
merged 23 commits into from Oct 9, 2022
Merged

rework serializers #155

merged 23 commits into from Oct 9, 2022

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Oct 6, 2022

  • SerializerInterface interface
    • BREAKING: renamed to Serializer
    • BREAKING: Method serialize() got a new optional parameter $prettyPrint
  • BaseSerializer abstract class
    • BREAKING: complete redesign
  • {Json,Xml}Serializer class
    • BREAKING: complete redesign

fixes #138

  • implement
  • update tests
  • write docs & HISTORY

@jkowalleck jkowalleck added this to the v2 milestone Oct 6, 2022
@jkowalleck jkowalleck force-pushed the serializer-injectable-normalizers branch 6 times, most recently from e9a9420 to fe6d735 Compare October 8, 2022 06:53
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the serializer-injectable-normalizers branch from fe6d735 to 5fe8abd Compare October 8, 2022 07:07
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the serializer-injectable-normalizers branch from ebe4539 to 9e7340d Compare October 8, 2022 11:36
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the serializer-injectable-normalizers branch 2 times, most recently from e29166c to 1d2770d Compare October 8, 2022 13:32
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the serializer-injectable-normalizers branch from 1d2770d to ce641eb Compare October 8, 2022 13:38
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the serializer-injectable-normalizers branch from 68c7fb1 to 807a442 Compare October 8, 2022 14:54
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the serializer-injectable-normalizers branch from 43967ed to 5abadc9 Compare October 8, 2022 22:13
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the serializer-injectable-normalizers branch from 9d801c1 to a72860e Compare October 9, 2022 12:23
@jkowalleck jkowalleck marked this pull request as ready for review October 9, 2022 12:24
@jkowalleck jkowalleck requested a review from a team as a code owner October 9, 2022 12:24
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the serializer-injectable-normalizers branch 8 times, most recently from 2e5f85a to 25d1714 Compare October 9, 2022 19:35
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the serializer-injectable-normalizers branch from 25d1714 to 0b5601e Compare October 9, 2022 19:42
@jkowalleck jkowalleck merged commit e888b67 into master Oct 9, 2022
@jkowalleck jkowalleck deleted the serializer-injectable-normalizers branch October 9, 2022 19:45
jkowalleck added a commit that referenced this pull request Oct 9, 2022
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rework serializers
1 participant