Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix possible XML anyURI violations #34

Merged
merged 1 commit into from Dec 3, 2021
Merged

fix possible XML anyURI violations #34

merged 1 commit into from Dec 3, 2021

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Dec 2, 2021 •
edited

closes #35

  • reproduce issue in a unittest
  • fix the issue

@jkowalleck jkowalleck changed the title reproduced cyclonedx-php-composer/issues/158 fix possible XML anyURI violations Dec 2, 2021
@jkowalleck jkowalleck added the bug Something isn't working label Dec 2, 2021
@jkowalleck jkowalleck self-assigned this Dec 2, 2021
@jkowalleck jkowalleck changed the title fix possible XML anyURI violations fix possible XML anyURI violations Dec 2, 2021
@jkowalleck jkowalleck force-pushed the cdx-php-composer_issue158 branch 5 times, most recently from 5a746b4 to 98865e4 Compare December 3, 2021 11:37
@jkowalleck
fix XML encoding for anyURI
62e615e 
related to #35

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck marked this pull request as ready for review December 3, 2021 11:44
@jkowalleck jkowalleck requested a review from a team as a code owner December 3, 2021 11:44
@jkowalleck jkowalleck merged commit 07edc66 into master Dec 3, 2021
@jkowalleck jkowalleck deleted the cdx-php-composer_issue158 branch December 3, 2021 11:45
jkowalleck added a commit that referenced this pull request Dec 3, 2021
@jkowalleck
1.3.1
21c23b1 
* Fixed
  * XML serializer & DOM normalizer no longer generate invalid
    `XML::anyURI`. (via [#34])

[#34]: #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jkowalleck jkowalleck

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assert correct URLs
1 participant
@jkowalleck