Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: typehint consts #434

Merged
merged 1 commit into from May 5, 2024
Merged

style: typehint consts #434

merged 1 commit into from May 5, 2024

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented May 5, 2024

since php83 it is possible to static type class consts.
this is usefull when inheriting classes, and preventing wrong types on override that change the const ... downstream

no need to type consts in final classes

since this lib supports php<83, we cannot static type consts.
but we could add type annotations :D

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck requested a review from a team as a code owner May 5, 2024 20:44
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5e66545) 5214 5201 99.75%
Head commit (a19dd3d) 5214 (+0) 5201 (+0) 99.75% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#434) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@jkowalleck jkowalleck merged commit 6fc95e9 into master May 5, 2024
34 checks passed
@jkowalleck jkowalleck deleted the style/typehint-consts branch May 5, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant