Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial spec1.4 implementation #65

Merged
merged 8 commits into from
Sep 15, 2022
Merged

initial spec1.4 implementation #65

merged 8 commits into from
Sep 15, 2022

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jan 31, 2022

fixes #57

  • BREAKING changes
    • Interface \CycloneDX\Core\Spec\SpecInterface became internal, was public api. (via [initial spec1.4 implementation #65])
      This is done to prevent the need for future "breaking changed" when the schema requires additional spec implementations.
  • Changed
    • Method \CycloneDX\Core\Serialize\{DOM,JSON}\Normalizers\ExternalReferenceNormalizer::normalize throw DomainException when ExternalReference's type was not supported by the spec. (via [initial spec1.4 implementation #65])
      This is considered a non-breaking change, because the behaviour was already documented in the API, even though there was no need for an implementation before.
  • Added

from milestone tasks:

  • Add spec 1.4 schemas to schemas folder
  • Add JSF schemas to schemas folder - used in draft 1.4 as a reference
  • Add spec 1.4 schema validation

@jkowalleck jkowalleck added the schema 1.4 related to CycloneDX spec v1.4 label Jan 31, 2022
@jkowalleck jkowalleck self-assigned this Jan 31, 2022
@jkowalleck jkowalleck force-pushed the spec1.4-dev branch 2 times, most recently from a6cfa15 to c6854de Compare March 8, 2022 07:16
@jkowalleck jkowalleck added enhancement New feature or request QA Quality Assurance labels Sep 11, 2022
@jkowalleck jkowalleck modified the milestones: v2, spec 1.4 Sep 11, 2022
@jkowalleck jkowalleck changed the title spec1.4 basic implementation spec1.4 implementation Sep 11, 2022
@jkowalleck jkowalleck marked this pull request as ready for review September 11, 2022 11:53
@jkowalleck jkowalleck requested a review from a team as a code owner September 11, 2022 11:53
@jkowalleck jkowalleck modified the milestones: v2, spec 1.4 Sep 15, 2022
fixes #57

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title spec1.4 implementation initial spec1.4 implementation Sep 15, 2022
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request QA Quality Assurance schema 1.4 related to CycloneDX spec v1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make spec 1.4 available
1 participant