Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation is failing to build and publish since #93 was merged #106

Closed
madpah opened this issue Dec 21, 2021 · 7 comments
Closed

Documentation is failing to build and publish since #93 was merged #106

madpah opened this issue Dec 21, 2021 · 7 comments
Labels
CI Continuous Integration documentation Improvements or additions to documentation

Comments

@madpah
Copy link
Collaborator

madpah commented Dec 21, 2021

See https://github.com/CycloneDX/cyclonedx-python-lib/runs/4595932920?check_suite_focus=true.

This appears to be the case since #93 was merged.

FYI: @jkowalleck

@madpah madpah added bug Something isn't working documentation Improvements or additions to documentation CI Continuous Integration and removed bug Something isn't working labels Dec 21, 2021
@jkowalleck
Copy link
Member

python markdown requires importlib_metadata which is not installed. hm, that is strange.
will look into it.

@madpah
Copy link
Collaborator Author

madpah commented Dec 21, 2021

I can't get it to fail locally @jkowalleck ? Very weird.

@madpah
Copy link
Collaborator Author

madpah commented Dec 21, 2021

Last successful run (https://github.com/CycloneDX/cyclonedx-python-lib/runs/4584812203?check_suite_focus=true) pulled in a newer version of Installing markdown (3.3.6) than the latest attempt: Installing markdown (3.3.5)

@madpah
Copy link
Collaborator Author

madpah commented Dec 21, 2021

I'll regen poetry.lock @jkowalleck

@madpah
Copy link
Collaborator Author

madpah commented Dec 21, 2021

And when doing so I get this:

<debug>PackageInfo:</debug> Invalid constraint (importlib-metadata (>='4.4') ; python_version < "3.10") found in markdown-3.3.5 dependencies, skipping

@madpah
Copy link
Collaborator Author

madpah commented Dec 21, 2021

So - looks like the root cause is related to bumping flake8 >=4.0.1:

If we directly had markdown==3.3.6 as a dev-dependency:

poetry update                                                                                      
Updating dependencies
Resolving dependencies... (0.1s)

  SolverProblemError

  Because no versions of markdown match >3.3.6,<4.0.0
   and markdown (3.3.6) depends on importlib-metadata (>=4.4), markdown (>=3.3.6,<4.0.0) requires importlib-metadata (>=4.4).
  And because flake8 (4.0.1) depends on importlib-metadata (<4.3)
   and no versions of flake8 match >4.0.1,<5.0.0, markdown (>=3.3.6,<4.0.0) is incompatible with flake8 (>=4.0.1,<5.0.0).
  So, because cyclonedx-python-lib depends on both flake8 (^4.0.1) and markdown (^3.3.6), version solving failed.

@madpah
Copy link
Collaborator Author

madpah commented Dec 21, 2021

Isolating dependencies for documentation generation has resolved this immediate problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants