Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing Vulnerability comparator for sorting #246

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

RodneyRichardson
Copy link
Contributor

Partial fix for #245.

This should work when credits is not set.

Partial fix for CycloneDX#245.

Signed-off-by: Rodney Richardson <rodney.richardson@cambridgeconsultants.com>
Copy link
Contributor

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@@ -206,6 +207,41 @@ def test_empty_vulnerability(self, mock_uuid: Mock) -> None:
self.assertIsNone(v.analysis)
self.assertFalse(v.affects)

def test_sort(self) -> None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jkowalleck jkowalleck changed the title Make Vulnerability sortable fix: add missing Vulnerability comparator for sorting Jun 10, 2022
@jkowalleck jkowalleck merged commit c3f3d0d into CycloneDX:main Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants