Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow serializing of patch resolves items for xml #312

Closed
wants to merge 1 commit into from

Conversation

schlenk
Copy link
Contributor

@schlenk schlenk commented Oct 20, 2022

Add the necessary parts to serialize the resolves part of patches to XML.

fixes #313

@schlenk schlenk requested a review from a team as a code owner October 20, 2022 12:36
@jkowalleck
Copy link
Member

jkowalleck commented Oct 20, 2022

could you add tests?

@schlenk
Copy link
Contributor Author

schlenk commented Oct 20, 2022

I'll give it a try.

@jkowalleck
Copy link
Member

please be aware that there is currently a feature stop while v4 is in the making.
see https://github.com/CycloneDX/cyclonedx-python-lib/milestone/4
see #262

this means your feature might not be merged before v4 was drafted.
⚡ I would advice you to open an issue describing the feature you try to implement.
we then can discuss how the implementation process can be done in a coordinated way.

@schlenk
Copy link
Contributor Author

schlenk commented Oct 20, 2022

That is okay.
The patch will actually become smaller, as the serialization for issues is already there (just inside the release_notes, not for patches), noticed it while trying to write a test. So its basically is just a bit of code reuse.

Signed-off-by: Michael Schlenker <michael.schlenker@contact-software.com>
@jkowalleck jkowalleck added this to the 4.0.0 milestone Jan 12, 2023
@jkowalleck jkowalleck marked this pull request as draft January 12, 2023 17:25
@madpah madpah removed this from the 4.0.0 milestone Mar 20, 2023
@jkowalleck
Copy link
Member

jkowalleck commented Sep 22, 2023

any updates?
is this still relevvant?

@jkowalleck jkowalleck linked an issue Nov 16, 2023 that may be closed by this pull request
@jkowalleck jkowalleck added the bug Something isn't working label Nov 16, 2023
@schlenk
Copy link
Contributor Author

schlenk commented Nov 23, 2023

This seems to be fixed and obsolete with the new serialization since 4.0.

@schlenk schlenk closed this Nov 23, 2023
@schlenk schlenk deleted the serialize_resolves branch November 23, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The resolves entries of a Patch object are not serialized to XML
3 participants