Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include all fields of Component in __lt__ function for #586 #587

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

madpah
Copy link
Collaborator

@madpah madpah commented Apr 12, 2024

Fixes #586.

Signed-off-by: Paul Horton <paul.horton@owasp.org>
@madpah madpah added the bug Something isn't working label Apr 12, 2024
@madpah madpah self-assigned this Apr 12, 2024
@madpah madpah requested a review from a team as a code owner April 12, 2024 14:52
Copy link

codacy-production bot commented Apr 12, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d437c40) 4456 4136 92.82%
Head commit (8722458) 4456 (+0) 4136 (+0) 92.82% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#587) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@madpah madpah merged commit d784685 into main Apr 22, 2024
44 checks passed
@madpah madpah deleted the fix/component-ordering branch April 22, 2024 16:07
@jkowalleck
Copy link
Member

related by #540

@jkowalleck
Copy link
Member

this "fix" caused a lot of issues,
see #598

will revert it and draft a "better" version.

@madpah FYI

jkowalleck added a commit that referenced this pull request Apr 26, 2024
reverts #587 - as this one introduced errors
fixes #598
fixes #586

---------

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Paul Horton <paul.horton@owasp.org>
Co-authored-by: Paul Horton <paul.horton@owasp.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Component __lt__ function can result in invalid components SortedSet
2 participants