Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conda-parser): build-number recognition for non-numerics #332

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Mar 19, 2022

conda packacge string parser no longer raises unexpected errors,
if the build-number is non-numeric.

fixes #331

@jkowalleck jkowalleck requested a review from a team as a code owner March 19, 2022 09:34
@jkowalleck jkowalleck marked this pull request as draft March 19, 2022 09:38
@jkowalleck jkowalleck force-pushed the bugfix/conda_buildversion_parsing_non-numeric branch 2 times, most recently from 2dda7d0 to b411736 Compare March 19, 2022 10:55
@jkowalleck jkowalleck marked this pull request as ready for review March 19, 2022 10:56
@jkowalleck jkowalleck force-pushed the bugfix/conda_buildversion_parsing_non-numeric branch from b411736 to dd0c76a Compare March 19, 2022 10:56
conda packacge string parser no longer raises unexpected errors,
if the build-number is non-numeric.
fixes #331

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the bugfix/conda_buildversion_parsing_non-numeric branch from dd0c76a to 2932180 Compare March 19, 2022 11:00
@jkowalleck jkowalleck requested a review from madpah March 19, 2022 11:03
@jkowalleck jkowalleck changed the title fix(conda-parser): version recognition for strings fix(conda-parser): build-number recognition for non-numerics Mar 19, 2022
@jkowalleck jkowalleck merged commit 65246dd into master Mar 21, 2022
@jkowalleck jkowalleck deleted the bugfix/conda_buildversion_parsing_non-numeric branch March 21, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: conda-parser raises error when unexpected build-number is detected
2 participants