Add ability to configure via Cargo.toml metadata #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add GeneratedSbom struct and moved file output responsbility to it Resolves CycloneDX#74 Paired with @amy-keibler Signed-off-by: Allie Sierra <85902135+allisonsierra@users.noreply.github.com>
We were setting the CLI SbomConfig to always have something set for included_dependencies. This meant that during the config merge this SbomConfig was always overriding package metadata configuration. Now we set included_dependencies to None so that the merge works as expected. Signed-off-by: Allie Sierra <85902135+allisonsierra@users.noreply.github.com>
3 tasks
allisonsierra
force-pushed
the
74-cargo-metadata
branch
from
14a6f6d
to
9d4b0cc
Compare
Adds the --top-level CLI argument to allow for configuration in manifest metadata to be overridden on the command line. Placed all and --top-level in argument group to make them mutually exclusive options. Signed-off-by: Allie Sierra <85902135+allisonsierra@users.noreply.github.com>
allisonsierra
force-pushed
the
74-cargo-metadata
branch
from
9d4b0cc
to
844135e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GeneratedSbom struct and moved file output responsbility to it
Resolves #74
Paired with @amy-keibler
Signed-off-by: Allie Sierra 85902135+allisonsierra@users.noreply.github.com