Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dependency graph #344

Closed

Conversation

serbanrobu
Copy link

Resolves: #14

@serbanrobu serbanrobu requested a review from a team as a code owner December 8, 2022 15:57
package
.dependencies()
.iter()
.find(|d| d.matches_id(p.package_id()))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compiler-message: error: called is_some() after searching an Iterator with find
--> cargo-cyclonedx/src/generator.rs:174:18
|
174 | .find(|d| d.matches_id(p.package_id()))
| ^
175 | | .is_some()
| |
________^ help: use any() instead: any(|d| d.matches_id(p.package_id()))
|
note: the lint level is defined here
--> cargo-cyclonedx/src/lib.rs:19:9
|
19 | #![deny(clippy::all)]
| ^^^^^^^^^^^
= note: #[deny(clippy::search_is_some)] implied by #[deny(clippy::all)]
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@serbanrobu serbanrobu force-pushed the add-support-for-dependency-graph branch from 624e567 to 24dbb37 Compare December 8, 2022 16:09
Sebastian Robu and others added 3 commits December 9, 2022 16:09
Signed-off-by: Sebastian Robu <srobu@sonatype.com>
Signed-off-by: Sebastian Robu <srobu@sonatype.com>
Signed-off-by: Amelia Keibler <amelia.keibler@gmail.com>
@serbanrobu serbanrobu force-pushed the add-support-for-dependency-graph branch from d3dd6cf to d232a6e Compare December 9, 2022 14:11
@erik-moqvist
Copy link

Any update on this PR? I'm also interested in having a dependency graph in the SBOM.

@lfrancke
Copy link
Contributor

lfrancke commented Oct 6, 2023

Yes, this will be worked on in the next few weeks.
I reached out to the author of this PR as well.

We're not allowed to talk about it yet but will have an announcement in the week of Oct 16 on the future of this project.
I would ask for just a tiny bit more patience.

@lfrancke
Copy link
Contributor

See #504 for an updated version of this PR.
I will close this for now. If anyone objects let me know.

@lfrancke lfrancke closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for dependency graph introduced in v1.2 of the spec
4 participants