Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance package.json finder #1284

Closed
jkowalleck opened this issue May 23, 2024 · 3 comments
Closed

feat: enhance package.json finder #1284

jkowalleck opened this issue May 23, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jkowalleck
Copy link
Member

in case the found package.json was invalid/insufficient,
the process should traverse up and find the next one.
this upwards traversal is to be stopped as soon as one of the following occurs:

  • the base name of the search path is node_modules
  • the search pat s the detected project root path
@jkowalleck jkowalleck added the enhancement New feature or request label May 23, 2024
This was referenced May 23, 2024
Open
Closed
Closed
@jkowalleck
Copy link
Member Author

closes #1237 #778

@jkowalleck jkowalleck added help wanted Extra attention is needed good first issue Good for newcomers labels May 23, 2024
@reey reey mentioned this issue Jun 10, 2024
Merged
@jkowalleck
Copy link
Member Author

oh, i have an addition, regarding yarn/pnp installs:
we need also to stop traversing up, as soon as the base name ends with .zip

jkowalleck added a commit that referenced this issue Jun 17, 2024
@reey @jkowalleck
feat: enhance package.json finder (#1286)
bffa22b 
implements #1284

For assets loaded from a subdirectory of `node_modules`, it will pick
the first `package.json` that actually has `name` and `version`
attributes.
Added a testcase for this, which verifies this functionality for the
`luxon` and `libphonenumber-js` packages.
The `package.json` for `libphonenumber-js/max` [misses a version
number](https://unpkg.com/browse/libphonenumber-js@1.11.3/max/package.json)
while for `luxon` [the name is
missing](https://unpkg.com/browse/luxon@3.4.4/src/package.json).

The snapshot has quite a lot of changes:
- For some reason the `purl` entries are no longer url encoded.
- The `@apollo/client/*` entries have been merged into a single
`@apollo/client` entry
- The `@babel/runtime` was added as dependency

---------

Signed-off-by: Tristan Bastian <tristan.bastian@softwareag.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Co-authored-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Copy link
Member Author

jkowalleck commented Jul 15, 2024 •
edited
Loading

#1286 should have addressed and fixed all issues.
Thanks to @reey 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkowalleck