Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test data, closes #294 #295

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Fix test data, closes #294 #295

merged 1 commit into from
Sep 11, 2023

Conversation

tokcum
Copy link
Contributor

@tokcum tokcum commented Sep 11, 2023

Fixes an inconsistency in test data of valid-service. First experienced in valid-service-1.4.json, other files (other versions and filetypes) showed the same deviation. The fix was derived from working test data of valid-service.

closes #294

Signed-off-by: tokcum <tobias.mucke@gmail.com>
@jkowalleck jkowalleck requested a review from a team September 11, 2023 11:59
@jkowalleck jkowalleck merged commit 4b65d83 into CycloneDX:master Sep 11, 2023
5 checks passed
jkowalleck pushed a commit to jkowalleck/fork_CycloneDX-specification that referenced this pull request Sep 11, 2023
…ce` (CycloneDX#295)

Fixes an inconsistency in test data of valid-service. First experienced in valid-service-1.4.json, other files (other versions and filetypes) showed the same deviation. The fix was derived from working test data of valid-service.

closes CycloneDX#294


Signed-off-by: tokcum <tobias.mucke@gmail.com>
jkowalleck added a commit to jkowalleck/fork_CycloneDX-specification that referenced this pull request Sep 11, 2023
forward-port of CycloneDX#295
fixes CycloneDX#294 in 1.6

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added the test-data related to test-resources and -data label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-data related to test-resources and -data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken test data in valid-service-1.x.json
2 participants