Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for redaction to compositions #410

Closed
wants to merge 1 commit into from
Closed

Add support for redaction to compositions #410

wants to merge 1 commit into from

Conversation

stevespringett
Copy link
Member

@stevespringett stevespringett commented Mar 23, 2024 •
edited by jkowalleck
Loading

Closes #409

  • modify JSON schema
  • modify XML schema
  • modify protobuf schema
  • add examples & test resources -- not needed for a new case in an existing enum

@stevespringett
Add support for redaction to compositions
d329585 
Signed-off-by: Steve Springett <steve@springett.us>
@stevespringett stevespringett added this to the 1.6 milestone Mar 23, 2024
@stevespringett stevespringett self-assigned this Mar 23, 2024
@stevespringett stevespringett requested a review from a team as a code owner March 23, 2024 05:42
@stevespringett
Copy link
Member Author

I'm actually on the fence on whether compositions is the right place for this or not.

@jkowalleck jkowalleck requested a review from a team March 23, 2024 11:14
@jkowalleck jkowalleck linked an issue Mar 23, 2024 that may be closed by this pull request
Add support for redaction #409
Open
@stevespringett stevespringett added the tc54 reviewed Ecma TC54 has reviewed the feature candidate label Mar 28, 2024
prabhu
prabhu reviewed Mar 29, 2024
View reviewed changes
schema/bom-1.6.proto
AGGREGATE_INCOMPLETE_THIRD_PARTY_OPENSOURCE_ONLY = 9;
// The information has been redacted.
AGGREGATE_REDACTED = 10;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redaction could happen only on first-party components while third-party information might be complete

@stevespringett stevespringett modified the milestones: 1.6, 1.7 Apr 7, 2024
Base automatically changed from 1.6-dev to master April 9, 2024 05:13
@stevespringett stevespringett deleted the 1.6-dev-redaction branch April 9, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhu prabhu prabhu left review comments

@jkowalleck jkowalleck jkowalleck approved these changes

Assignees

@stevespringett stevespringett

Labels
proposed core enhancement tc54 reviewed Ecma TC54 has reviewed the feature candidate
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

Add support for redaction
3 participants
@stevespringett @prabhu @jkowalleck