-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revisit new component identifiers #419
fix: revisit new component identifiers #419
Conversation
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@@ -597,15 +597,15 @@ limitations under the License. | |||
</xs:documentation> | |||
</xs:annotation> | |||
</xs:element> | |||
<xs:element name="omniborId" type="xs:anyURI" minOccurs="0" maxOccurs="unbounded"> | |||
<xs:element name="omniborId" type="xs:string" minOccurs="0" maxOccurs="unbounded"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a string in JSON and protobuf, so lets stick to strings here, too.
<xs:annotation> | ||
<xs:documentation> | ||
Specifies the OmniBOR Artifact ID. The OmniBOR, if specified, MUST be valid and conform | ||
to the specification defined at: https://www.iana.org/assignments/uri-schemes/prov/gitoid | ||
</xs:documentation> | ||
</xs:annotation> | ||
</xs:element> | ||
<xs:element name="swhid" type="xs:anyURI" minOccurs="0" maxOccurs="unbounded"> | ||
<xs:element name="swhid" type="xs:string" minOccurs="0" maxOccurs="unbounded"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a string in JSON and protobuf, so lets stick to strings here, too.
@@ -7,9 +7,10 @@ | |||
<version>1.0.0</version> | |||
<cpe>cpe:2.3:a:example:acme-library:1.0.0:*:*:*:*:*:*:*</cpe> | |||
<purl>pkg:maven/com.example/acme-library@1.0.0</purl> | |||
<omnibodId>gitoid:blob:sha1:261eeb9e9f8b2b4b0d119366dda99c6fd7d35c64</omnibodId> | |||
<omniborId>gitoid:blob:sha1:261eeb9e9f8b2b4b0d119366dda99c6fd7d35c64</omniborId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was off ...
something was off in the test data - https://github.com/CycloneDX/specification/actions/runs/8476878829/job/23227006633?pr=323#step:5:874
here is the fix