Add blacklist of friendly mobs that hostile potion abilities don't affect. #60
Conversation
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private static java.util.Set<ResourceLocation> friendlyMobs = null; |
There was a problem hiding this comment.
Any reason why you aren't just importing Set?
| static boolean isFriendlyMob(EntityLivingBase mob, EntityPlayer player) { | ||
|
|
||
| if (friendlyMobs == null) { | ||
| friendlyMobs = new java.util.HashSet<ResourceLocation>(); |
| private static java.util.Set<ResourceLocation> friendlyMobs = null; | ||
|
|
||
| static boolean isFriendlyMob(EntityLivingBase mob, EntityPlayer player) { | ||
|
|
| /** | ||
| * Mobs that are immune to hostile potion effect abilities | ||
| */ | ||
| @ConfigurableProperty(category = ConfigurableTypeCategory.GENERAL, comment = "These mobs will not be affected by hostile area potion effects such as poison or weakness.") |
There was a problem hiding this comment.
requiresMcRestart should be set to true, due to how you have implemented config value synchronization.
Alternatively, you could set a changedCallback so that this list can be changed at runtime. (EvilCraft does this, if you need an example).
The second option would be nicer, but not required.
|
@CplPibald Also, could you sign the CLA? (It's something I just enabled) |
|
I approve of the CLA and I agree with the terms presented in the Cyclops Contributor License Agreement. However, when I try to click the agree link, the app requests way too many permissions for me to be comfortable with, such as reading and writing to all of my repos and public and private gists. See cla-assistant/cla-assistant#243 and cla-assistant/cla-assistant#78 |
|
@CplPibald Did you try directly going to https://cla-assistant.io/CyclopsMC/CyclopsCore as someone in one of those issues suggested? Haven't checked myself, but that may require less permissions. (No problem if that's not the case) |
…ging config doesn't require a restart.
|
Great, thanks! |
Fix for #41 as discussed.