Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LargeLiteralValueDetector: handle hex literals & underscore separators #396

Merged
merged 8 commits into from
May 6, 2024

Conversation

kevincharm
Copy link
Contributor

gmeow, I noticed this false positive while trying out aderyn on a codebase with large hex literals.

This PR adds detection for:

  • Hexadecimal literals
  • Separators
  • Exponents

@kevincharm kevincharm requested a review from alexroan as a code owner May 6, 2024 00:08
@alexroan
Copy link
Contributor

alexroan commented May 6, 2024

Resolved #397 in the process of polishing this one.

@alexroan alexroan merged commit c70d063 into Cyfrin:dev May 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants