Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corrected contract name for OracleLibTest #25

Merged
merged 1 commit into from
Jul 6, 2023
Merged

corrected contract name for OracleLibTest #25

merged 1 commit into from
Jul 6, 2023

Conversation

ShayanShamsi
Copy link
Contributor

Since here we are testing OracleLib.sol and we already have a contract named DSCEngineTest in DSCEngineTest.t.sol that is testing DSCEngine.sol, I thought it would be more appropriate if this test contract was named OracleLibTest instead of DSCEngineTest.

@PatrickAlphaC
Copy link
Member

Ah great addition! Thank you!

@PatrickAlphaC PatrickAlphaC merged commit 11e561d into Cyfrin:main Jul 6, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShayanShamsi @PatrickAlphaC