fix: Make sure the decoder options isn't freed #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This caused the decoding options to not work as intended - valgrind was unhappy Signed-off-by: Hubert Figuière <hub@figuiere.net>
gnomesysadmins
pushed a commit
to GNOME/niepce
that referenced
this pull request
Apr 13, 2024
The images however are pre-rotated as we can't disable it due to bug Cykooz/libheif-rs#21 Instead we reset the Exif orienation to 1. Signed-off-by: Hubert Figuière <hub@figuiere.net>
gnomesysadmins
pushed a commit
to GNOME/niepce
that referenced
this pull request
Apr 13, 2024
The images however are pre-rotated as we can't disable it due to bug Cykooz/libheif-rs#21 Instead we reset the Exif orienation to 1. Signed-off-by: Hubert Figuière <hub@figuiere.net>
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the as_ref(), the decoding_options gets dropped, dropping the allocated inner. Then the values inside become garbage, including
ignore_transformations.Note: there is no testing of this in the teste suite. I couldn't figure out how make a proper sample as merely changing the
orientationwith ExifTool isn't enough. If I figure it out, I can submit a PR testingignore_transformations.