Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roughness multi input #102

Open
wants to merge 13 commits into
base: development
Choose a base branch
from
Open

Roughness multi input #102

wants to merge 13 commits into from

Conversation

AliceHarang
Copy link
Collaborator

@AliceHarang AliceHarang commented Feb 13, 2024

  • : Add the possibility to use multiple roughness files
  • : Add Test for the multiple roughness files use
  • : Add Test for the multiple bathy files
  • : Update the automatic testing

Complementary:

  • : Add value input for IL/CL
  • : Add test for this value input

@AliceHarang
Copy link
Collaborator Author

After creating the test, I observe a weird behavior when the value is 0 (for bathy and roughness).

@CyprienBosserelle
Copy link
Owner

Would be neat to fix this one as well:
#105

@AliceHarang
Copy link
Collaborator Author

I have also finished to add the possibility to have a Continuous Loss and Initial Loss as a constant.

@CyprienBosserelle
Copy link
Owner

I had a quick look again and the way the "NaN" values are removed is the most appropriate way.
There is now a built -in mechanism to remove NAN from input/forcing maps but in the case of vector of map we only want to remove the value from the top map and leave large hole in the data intact for the other maps.

@CyprienBosserelle
Copy link
Owner

if the test succeed please go ahead and merge.
C

Copy link
Owner

@CyprienBosserelle CyprienBosserelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants