Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding atmospheric pressure forcing #57

Merged
merged 24 commits into from
Mar 10, 2022
Merged

Adding atmospheric pressure forcing #57

merged 24 commits into from
Mar 10, 2022

Conversation

CyprienBosserelle
Copy link
Owner

@CyprienBosserelle CyprienBosserelle commented Mar 4, 2022 •
edited

  • Add/fix pressure forcing
  • Fix Kurganov engine for Pressure forcing
  • Add flags for switching engine

@CyprienBosserelle CyprienBosserelle marked this pull request as ready for review March 4, 2022 07:43
@CyprienBosserelle CyprienBosserelle marked this pull request as draft March 4, 2022 22:24
@CyprienBosserelle CyprienBosserelle marked this pull request as ready for review March 5, 2022 03:52
AliceHarang
AliceHarang approved these changes Mar 7, 2022
View reviewed changes
Copy link
Collaborator

@AliceHarang AliceHarang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice developments and quite a lot of warning fixed!
I think it would be great to put the ref paper in the model choice (param.h file) and also add a quick simple testcase with an atm forcing (and also testing the "deformation" in the same one?)

src/Param.h Outdated
@@ -42,6 +42,8 @@ class Param {

int doubleprecision = 0; // 0: float precision, 1: double precision

int engine = 1; // 1: Buttinger, 2: Kurganov, 3: KurganovATMP
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add paper reference ?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I updated the description with a citing reference. Full reference is in the function documentation.

@CyprienBosserelle
Copy link
Owner Author

CyprienBosserelle commented Mar 8, 2022 •
edited

Since there is a lot of fix in this branch (many unrelated to atm pressure) I will merge this to for deform and atmp forcing.

@CyprienBosserelle CyprienBosserelle merged commit 61d69d3 into development Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliceHarang AliceHarang AliceHarang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CyprienBosserelle @AliceHarang