Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to XBeach-GPU parameter conversion script #56

Closed
davidbenncsiro opened this issue Aug 1, 2023 · 3 comments · Fixed by #57
Closed

Improvements to XBeach-GPU parameter conversion script #56

davidbenncsiro opened this issue Aug 1, 2023 · 3 comments · Fixed by #57
Assignees
@davidbenncsiro
Labels
enhancement
Projects
Improve input and outputs management

Comments

@davidbenncsiro
Copy link
Collaborator

There have been more improvements to the XBeach-GPU parameter conversion script since #53
@davidbenncsiro davidbenncsiro self-assigned this Aug 1, 2023
davidbenncsiro added a commit that referenced this issue Aug 1, 2023
@davidbenncsiro
#56: numerous improvements to the script after pre software publicati…
be189db 
…on review and refactoring; removed/added data directory contents; updated UTs after posdown param added to manual; removed requirements.txt since now no dependency on params library
@davidbenncsiro davidbenncsiro linked a pull request Aug 1, 2023 that will close this issue
#56: Improvements to the script after review #57
Merged
@davidbenncsiro davidbenncsiro mentioned this issue Aug 1, 2023
Merged
@davidbenncsiro
Copy link
Collaborator Author

Hi @CyprienBosserelle, please let me know if you have questions or comments on these improvements to the script via the pull request. Thanks.

@davidbenncsiro
Copy link
Collaborator Author

Hi @CyprienBosserelle, just a gentle reminder about the open pull request associated with this issue. Thanks. :)

@davidbenncsiro davidbenncsiro mentioned this issue Oct 9, 2023
Closed
davidbenncsiro added a commit that referenced this issue Oct 9, 2023
@davidbenncsiro
#56: changing grdalfa to grdalpha
19fef62
@davidbenncsiro
Copy link
Collaborator Author

@CyprienBosserelle since this pull request is still open and Emilio Echevarria just found the grdalpha bug, I have committed the corresponding fix for alfa to grdalpha here. Note that the unit tests will fail until #59 is reviewed and merged back to gh-pages.

@davidbenncsiro davidbenncsiro linked a pull request Oct 9, 2023 that will close this issue
#59: changing grdalfa to grdalpha in General Parameters table #60
Merged
@davidbenncsiro davidbenncsiro removed a link to a pull request Oct 9, 2023
#59: changing grdalfa to grdalpha in General Parameters table #60
Merged
davidbenncsiro added a commit that referenced this issue Oct 13, 2023
@davidbenncsiro
#56: fixed case where XB param key or value had leading/trailing spaces
744dc8f
davidbenncsiro added a commit that referenced this issue Nov 3, 2023
@davidbenncsiro
#56: changed function from full_output_path to xb2xbg_file_path
8f741c6
davidbenncsiro added a commit that referenced this issue Nov 3, 2023
@davidbenncsiro
#56: replacing .txt in depfile
5459a6e
davidbenncsiro added a commit that referenced this issue Nov 6, 2023
@davidbenncsiro
#56: removed xb2xbg; moved to public CSIRO repo
efdc73b
davidbenncsiro added a commit that referenced this issue Nov 6, 2023
@davidbenncsiro
Merge pull request #57 from CyprienBosserelle/56-improvements-to-xbea…
613fa93 
…ch-gpu-parameter-conversion-script

#56: Improvements to the script after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidbenncsiro davidbenncsiro

Labels
enhancement
Projects
Improve input and outputs management
Awaiting triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#56: Improvements to the script after review CyprienBosserelle/xbeach_gpu
1 participant
@davidbenncsiro