Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code modernisation #38

Closed
TimothyMakkison opened this issue Dec 3, 2022 · 3 comments
Closed

Code modernisation #38

TimothyMakkison opened this issue Dec 3, 2022 · 3 comments

Comments

@TimothyMakkison
Copy link
Contributor

TimothyMakkison commented Dec 3, 2022

Optimize and modernise code to be in parity with System.Guid

Modernisation

Optimisation

  • Use string.Create where possible
  • Vectorize the ToGuid, public Ulid(Guid guid) shuffle.
  • Vectorize equality Vectorize Equality #37
  • Vectorize Comparison see Guid.FastCompareTo
  • Consider vectorizing TryWriteStringify
  • Vectorize internal Ulid(long timestampMilliseconds timestamp shuffling
  • Vectorize internal Ulid(ReadOnlySpan<char> base32)
  • Vectorize public DateTimeOffset Time
@github-actions
Copy link
Contributor

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jun 18, 2023
@neuecc neuecc reopened this Jul 18, 2023
@neuecc
Copy link
Member

neuecc commented Jul 18, 2023

sorry for the delayed response, PR will check in next month.

@github-actions github-actions bot removed the stale label Jul 19, 2023
@hadashiA
Copy link
Member

#39 merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants