Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add System.Diagnostics.DiagnosticSource.dll #74

Merged
merged 2 commits into from Oct 5, 2023
Merged

Conversation

hadashiA
Copy link
Member

@hadashiA hadashiA commented Sep 22, 2023

#66

in Unity 2021.3 or newer, The following error seems to have occurred during installation.

Assembly 'Assets/Plugins/Microsoft.Extensions.Logging.dll' will not be loaded due to errors:
Unable to resolve reference 'System.Diagnostics.DiagnosticSource'. Is the assembly missing or incompatible with the current platform?
Reference validation can be disabled in the Plugin Inspector.
  • Simply I added the System.Diagnostics.DiagnosticSource.dll file in the package.
  • The minimum supported version is specified in package.json.

Consideration

If the minimum supported version is 2021.3, there is no need to separate the netstandard 2.0 and 2.1 packages.

  • Unity2021.3 + .NET Standard 2.1 dlls : ✅
  • Unity2021.3 + .NET Framework dlls : ✅

@hadashiA
Copy link
Member Author

hadashiA commented Sep 29, 2023

According to the issue comments, the windows target does not require additional dlls (?) 🤔 🤔
I would like to investigate this further.

@hadashiA
Copy link
Member Author

hadashiA commented Oct 5, 2023

I tried to follow up in a Windows environment.

In all environments, System.Diagnostics.DiagnosticsSource.dll was missing.

  • Unity 2021.3 + .NET Standard 2.1 Target=Windows : ✅
  • Unity 2021.3 + .NET Standard 2.1 Target=Android : ✅
  • Unity 2021.3 + .NET Framework Target=Windows : ✅
  • Unity 2021.3 + .NET Framework Target=Android : ✅

@hadashiA hadashiA merged commit c6840b1 into master Oct 5, 2023
2 checks passed
@hadashiA hadashiA deleted the hadashiA/unity20213 branch October 5, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant