Server and Global Scores Display Current User in "Highest streak" if the Highest Streak is 1

[CzarHey]

On a server where the command has never been used before, or in a server where all of the scores have been reset, all of the scores variables are empty. The "Highest streak" section in the scoreboard will display "None yet!"

If a user is bombed and defuses the bomb successfully, the scoreboard will record their streak as "1", but will incorrectly display the username of the user who requested the command rather than the user who defused the bomb.

If another user is able to get a streak of 2 or higher, the scoreboard will display the correct username. The issue will not appear again unless the scoreboard is reset.

This issue has been noted on both the Public Tags and Custom Command version. It's been observed only on the local server score streak, but is believed to also affect the global score streak as well, as the code between the two is very similar.

[CzarHey]

I think I found the culprit of this issue. It's on Line 457 - 460 of the CC version (the code's similar in the PT version but whatever).

{//;If not null, check to see if the current streak is higher than the streakrecord}{if;{get;timebomb-scores-streak-{get;~victim}};>;{get;timebomb-scores-streakrecord-total};
	{//;If it's higher, set streakrecord to match score-streak}{set;timebomb-scores-streakrecord-total;{get;timebomb-scores-streak-{get;~victim}}}
	{//;Note down the victim's user ID as they are the new crown-holder}{set;timebomb-scores-streakrecord-crown;{get;~victim}}
}

Here's what I'm guessing is causing the issue:

• When a user successfully defuses a bomb, the "if" check checks to see if the victim's streaks score is higher than the recorded total. If it is, then it will run the code that sets the new streaks record holder. If it is equal to or lower, then it doesn't run anything.
• The problem is that, when a user first defuses a bomb, both their user highest streak and the server's highest streak counts are 1. The code is checking to see if the user highest streak is greater than the server's highest streak. Since they are equal, the code that would set the "Who is the current record holder" variable is never run, so that variable remains blank.
• The Scores display output uses the "person" Public Tag to display user info. If that tag is not given a user ID, it will return the current user's information. Since the "Who is the current record holder" variable is blank, it returns the current user ID, and therefore that's why the Scores display output shows the current user rather than the defusing user.
• If someone gets a streak higher than 1, that will cause the code to execute and thus correctly set the record-holder.

If I had more time, I'd write a shorter letter. But this is what I've gathered from the issue, and at least now I know what's causing it.