Feature/rework the entity classes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 5, 2020 21:23
Adding interfaces for entites, position, velocity and the physic engine
Adding new interfaces for better implementation Cleaning up yesterday created interfaces Correcting structure Adding base classes Reworking systems
Getting the new systems to a working state
Adding new files to the project
XanatosX
commented
Feb 18, 2020
Tank/src/Systems/AbstractSystem.cs
Outdated
| } | ||
|
|
||
| /// <summary> | ||
| /// This method will check if an entity id is relevant for this system. It will check against the validateable list |
There was a problem hiding this comment.
text should use two lines
XanatosX
commented
Feb 18, 2020
Tank/src/Systems/DamageSystem.cs
Outdated
| { | ||
| if (component is PlaceableComponent) | ||
| { | ||
| Vector2 explosionPosition = new Vector2(collisionEvent.CollisionPosition.X, collisionEvent.CollisionPosition.Y); |
There was a problem hiding this comment.
Line is to long a line break should be added
XanatosX
commented
Feb 18, 2020
Tank/src/Systems/PhysicSystem.cs
Outdated
|
|
||
| Vector2 oldPosition = placeComponent.Position; | ||
| placeComponent.Position += objVelocity; | ||
| placeComponent.Rotation = (float)Math.Atan2(placeComponent.Position.Y - oldPosition.Y, placeComponent.Position.X - oldPosition.X); |
There was a problem hiding this comment.
Line is to long a line break should be added
XanatosX
commented
Feb 18, 2020
Tank/src/Systems/RenderSystem.cs
Outdated
| { | ||
| continue; | ||
| } | ||
| spriteBatch.Draw(visibleComponent.Texture, visibleComponent.Destination, visibleComponent.Source, visibleComponent.Color, placeableComponent.Rotation, Vector2.Zero, SpriteEffects.None, 1f); |
There was a problem hiding this comment.
Line is to long a line break should be added
added 12 commits
February 18, 2020 21:45
Changed field order
Removed comment line
Adding missing summaries
Adding missing summary blocks
XanatosX
commented
Feb 19, 2020
| /// <param name="displace">The displace value to use</param> | ||
| /// <param name="roughness">The roughness to use</param> | ||
| /// <param name="randomizer">The randomizer to use</param> | ||
| public MidpointDisplacementGenerator(GraphicsDevice graphicsDevice, float displace, float roughness, IRandomizer randomizer) |
This was referenced Feb 19, 2020
Closed
Closed
XanatosX
added a commit
that referenced
this pull request
Jan 11, 2022
…classes Feature/rework the entity classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.