Skip to content

Commit

Permalink
Revert 5929167 since content from previous jobs doesn't carry forward…
Browse files Browse the repository at this point in the history
… to future jobs

See: actions/checkout#19
  • Loading branch information
D-Pow committed Feb 26, 2023
1 parent ae844c9 commit abb9c6a
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 18 deletions.
19 changes: 8 additions & 11 deletions .github/workflows/cd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,6 @@ env:


jobs:
cd-init:
runs-on: ubuntu-latest
steps:
- name: Checkout repository branch
uses: actions/checkout@v2

- name: Set NodeJS version
uses: actions/setup-node@v2
with:
node-version: ${{ env.nodeVersion }}

cd-client-build:
runs-on: ubuntu-latest
needs: [ cd-init ]
Expand All @@ -91,6 +80,14 @@ jobs:
# - https://stackoverflow.com/questions/66205887/only-run-github-actions-step-if-not-a-pull-request/66206183#66206183
if: ${{ github.event_name != 'pull_request' && (github.event.pull_request.merged || github.ref == 'refs/heads/master') }}
steps:
- name: Checkout repository branch
uses: actions/checkout@v2

- name: Set NodeJS version
uses: actions/setup-node@v2
with:
node-version: ${{ env.nodeVersion }}

# Native GitHub `actions/download-artifact@v3` doesn't allow sharing between workflows.
# - Issue: https://github.com/actions/toolkit/issues/501
# Once it does, we can use:
Expand Down
11 changes: 4 additions & 7 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ env:
# See:
# - Reusable workflows `uses`: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_iduses
jobs:
ci-init:
ci-verify-build:
# The type of runner that the job will run on
runs-on: ubuntu-latest

Expand All @@ -61,7 +61,9 @@ jobs:

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it.
# Note: Files don't carry over between separate jobs so merge the git-checkout/env-setup
# logic in with the actual job logic.
- name: Checkout repository branch
uses: actions/checkout@v2

Expand All @@ -77,11 +79,6 @@ jobs:
ls -FlAh ..
ls -FlAh ../..
ci-build-and-upload-artifacts:
runs-on: ubuntu-latest
needs: [ ci-init ]
steps:
# Downloads previous runs' cache of content like node_modules/ for faster re-runs
- name: Client CI - Download cache
uses: actions/cache/restore@v3
Expand Down

0 comments on commit abb9c6a

Please sign in to comment.