Fix ice-invalid when initializing struct with an array #145
Conversation
|
Upstream PR: dlang/dmd#4310 |
|
|
||
| * init.c(ArrayInitializer::semantic): Fail when toExpression returns a | ||
| null pointer. | ||
|
|
There was a problem hiding this comment.
Upstream have their own changelog, you don't need this here. :-)
|
Which version of dmd did this fix make it into? Since I only take care to not make changes to code that is wrapped around |
|
I'm having a hard time understanding your comment :-) |
Since there are thousands of lines of changes between any given upstream release, I can't be expected to remember where every local change is. So the only marker I can rely upon is that code is wrapped around How that relates to this PR?
|
More likely, there will be two trees, one with 2.068, and another with 2.069+. The former will need to be able to bootstrap the latter until we have enough coverage with ports to make the switch over proper. Ideally, this means that there will be binaries for all primary GCC platforms. (https://gcc.gnu.org/gcc-5/criteria.html) As a compromise situation, we could always add logic to the build scripts so that if no D compiler exists, bootstrap 2.068 first. I think LDC are going to be doing this too when the time comes for them. |
|
OK, I get it ; thanks for explaining. |
Fix ice-invalid when initializing struct with an array
The following patch fixes a crash on the following invalid code:
struct S
{
}
S g =
[
{ 1[] }
];